-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade webpack to v5 #5969
Upgrade webpack to v5 #5969
Conversation
… and the plugin is included with webpack v5
…ease of 60% is too much for the marginal size gains of 5%
}, | ||
type: "asset", | ||
parser: { dataUrlCondition: { maxSize: 10000 } }, | ||
// generator: { mimetype: "application/font-woff" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find a way to specify the mimetype for the webpack asset modules. I found this syntax in some webpack PR but it doesn't work. None of our .woff files seem to be below 10k anyways, though, so maybe we can simply remove this dataUrlCondition and always include them as resources 🤷
@MichaelBuessemeyer Would be great if you could also test this PR, check out the branch on your machine, |
I didn't do a full review/test, but looks good to me! |
Glorious! Looks good and works well for me (locally and on dev instance) :) Let's wait for @MichaelBuessemeyer, though, so that he can test on OS X. |
Works perfectly for me under MacOS + Chrome 🎉 . |
process
,url
orpath
.cache.buildDependencies
.URL of deployed dev instance (used for testing):
Steps to test:
yarn install
and test whether webpack builds successfully on your machine(Please delete unneeded items, merge only when none are left open)