New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that rapid space-presses led to sped up movements #5947

Merged

philippotto merged 2 commits into master from fix-rapid-movement

Jan 7, 2022

Member

philippotto commented Jan 7, 2022 •

edited

Loading

URL of deployed dev instance (used for testing):

https://___.webknossos.xyz

Steps to test:

set keyboard delay to 500
set move value to 8000
press space rapidly in a dataset
--> on master, this will occasionally jump big values along z
--> on this branch, z should only increment by one

Issues:

fixes Sometimes keyboard delay isn't respected properly #3795

(Please delete unneded items, merge only when none are left open)

Updated (unreleased) changelog
Updated (unreleased) migration guide if applicable
Updated documentation if applicable
Adapted wk-connect if datastore API changes
Adapted wk-libs python client if relevant API parts change
Needs datastore update after deployment
Ready for review


          fix that rapid space-presses led to sped up movements

899973d

philippotto requested a review from normanrz

January 7, 2022 13:25

philippotto self-assigned this


          update changelog

2b589e4

normanrz approved these changes

View reviewed changes

Member

normanrz left a comment

SWEET!

philippotto enabled auto-merge (squash)

January 7, 2022 13:50

philippotto merged commit 1a3c67c into master

philippotto deleted the fix-rapid-movement branch

January 7, 2022 14:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet