Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that data was not rendered when zoomed in too much #5797

Merged
merged 4 commits into from
Nov 1, 2021

Conversation

daniel-wer
Copy link
Member

The earlier fix caused a regression, because it didn't distinguish between having zoomed in so much that a viewport is covered by only one bucket and a viewport not being visible at all. Both resulted in a height and width of 0 in bucket coordinates. I introduced a new flag which checks the actual viewport width which is a float and, therefore, is only 0 if the viewport is not visible.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Zoom in as much as possible in a dataset -> Data should always be rendered
  • I checked (via breakpoint) that the bucket picking is aborted if the 3D view is maximized (to confirm that Fix crashes related to maximizing/minimizing #5746 which was fixed with the code that caused the regression remains fixed)

Issues:


@daniel-wer daniel-wer added the bug label Oct 28, 2021
@daniel-wer daniel-wer self-assigned this Oct 28, 2021
@daniel-wer daniel-wer changed the title fix that data was not rendered when zoomed in too much Fix that data was not rendered when zoomed in too much Oct 28, 2021
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant fix 👍 Works perfectly, too. The changelog needs an update before merging :)

@bulldozer-boy bulldozer-boy bot merged commit 2c8f51e into master Nov 1, 2021
@bulldozer-boy bulldozer-boy bot deleted the fix-high-zoom branch November 1, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When zooming in too far, no data is rendered
2 participants