Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only poll api/jobs from meshes tab while logged in #5647

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Only poll api/jobs from meshes tab while logged in #5647

merged 1 commit into from
Aug 2, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 2, 2021

Steps to test:

  • set up jobsEnabled
  • set a dataset with a segmentation layer to public
  • open that dataset while logged out
  • no request to api/jobs should be sent

Issues:

@fm3 fm3 self-assigned this Aug 2, 2021
@fm3 fm3 requested a review from philippotto August 2, 2021 09:10
philippotto
philippotto approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fm3 fm3 merged commit 0b9b63b into master Aug 2, 2021
@fm3 fm3 deleted the dont-poll-jobs-if-logged-out branch August 2, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication error when clicking on the Meshes tab
2 participants
@fm3 @philippotto