Show converting datasets #5597
Show converting datasets #5597
Conversation
philippotto
requested review from
MichaelBuessemeyer and
daniel-wer
and removed request for
philippotto
|
I won't be able to get to this PR before my vacation. @MichaelBuessemeyer could you do the review and @daniel-wer maybe you could have a look at the UX and give some feedback? :) |
|
@youri-k What would be a good way to test this? The deployed dev instances don't seem to have the conversion ability 🤔 |
There was a problem hiding this comment.
Some UX suggestions :)
Although I set up webknossos-worker as described in the Readme, didn't get any errors and celery is running, the conversions don't seem to run. I probably misconfigured something or ran the wrong celery command. Still, I did see the blue banner (just with an UNKNOWN state).
| <Row key={job.id} gutter={16}> | ||
| <Col span={10}> | ||
| <Tooltip title={job.state}>{stateToIcon[job.state]}</Tooltip> | ||
| {` ${job.datasetName || "UNKNOWN"}`} |
There was a problem hiding this comment.
Is there any additional info that could be displayed here? For example, when the job was triggered and/or who triggered it.
There was a problem hiding this comment.
Thank you for your suggestion. I included the trigger date. All of the jobs that are visible are triggered by yourself, so there is not a benefit of displaying the "owner" of the job
There was a problem hiding this comment.
are you sure about this? won't admins see all jobs?
There was a problem hiding this comment.
(I think, you are right; even as a super admin, the jobs page also shows only my jobs)
Co-authored-by: Daniel <[email protected]>
…w-conversion-datasets
…w-conversion-datasets
…ally poll, adapt tooltips etc.
|
Great work, @youri-k! I made a couple of changes (e.g., I'm also showing successful conversions, since I think, that this will also be a nice feedback). I also added an auto refresh of the running jobs. Here's a screenshot: @MichaelBuessemeyer could you have a look at my last commit and give a final go? |
There was a problem hiding this comment.
@philippotto I only found two minor things. After they are resolved, this pr should be ready to go 🚢
| export const TOOLTIP_MESSAGES_AND_ICONS = { | ||
| UNKNOWN: { | ||
| tooltip: | ||
| "The status information for this job could not be retreived. Please try again in a few minutes, or contact us if you need assistance.", | ||
| icon: <QuestionCircleTwoTone twoToneColor="grey" />, | ||
| }, | ||
| SUCCESS: { | ||
| tooltip: "This job has successfully been executed.", | ||
| icon: <CheckCircleTwoTone twoToneColor="#49b21b" />, | ||
| }, | ||
| PENDING: { | ||
| tooltip: "This job will run as soon as a worker becomes available.", | ||
| icon: <ClockCircleTwoTone twoToneColor="orange" />, | ||
| }, | ||
| STARTED: { tooltip: "This job is currently running.", icon: <LoadingOutlined /> }, | ||
| FAILURE: { | ||
| tooltip: | ||
| "Something went wrong when executing this job. Feel free to contact us if you need assistance.", | ||
| icon: <CloseCircleTwoTone twoToneColor="red" />, | ||
| }, | ||
| MANUAL: { | ||
| tooltip: | ||
| "The job will be handled by an admin shortly, since it could not be finished automatically. Please check back here soon.", | ||
| icon: <ToolTwoTone twoToneColor="orange" />, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
I suggest using the predefined colors:
There was a problem hiding this comment.
I re-used these colors, but unfortunately I had to repeat the hex values, as the icon components don't support css variables (such as --ant-success). I checked that the icons look okay in light and dark themes. So, I think, this should be ready now.
There was a problem hiding this comment.
as the icon components don't support css variables
What a bummer 😕
…kingSpace and MAX_JOBS_TO_DISPLAY
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[x] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment