Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrapping Nested Tree Groups During Upload #5596

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 1, 2021

Fixes a bug where nested tree groups were messed up during NML upload if “Create a new tree group for this file.“ is selected.

The group structure is a list of groups which can each have a list of children. When determining the largest free id, these children have to be taken into account as well.

URL of deployed dev instance (used for testing):

Steps to test:

Issues:


@fm3 fm3 requested a review from youri-k July 1, 2021 13:18
@fm3 fm3 self-assigned this Jul 1, 2021
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit 12b9c56 into master Jul 12, 2021
@fm3 fm3 deleted the fix-wrap-nested-groups branch July 12, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing NML with nested groups messes up hierarchy when using "Create a new tree group for this file"
2 participants