Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add colored icons to status in jobs list #5594

Merged
merged 6 commits into from
Jul 8, 2021
Merged

Add colored icons to status in jobs list #5594

merged 6 commits into from
Jul 8, 2021

Conversation

grittaweisheit
Copy link
Contributor

@grittaweisheit grittaweisheit commented Jun 29, 2021 •
edited
Loading

This PR adds colored icons to the status entries in the job list.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • have some jobs
  • go to the "Processing Jobs" administration page
  • there should be colored icons in the status column, matching the status

Issues:

@grittaweisheit grittaweisheit self-assigned this Jun 29, 2021
@philippotto philippotto self-requested a review June 30, 2021 07:37
fm3
fm3 approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :) I took the liberty to change one color slightly. Code LGTM as well!

@fm3 fm3 assigned fm3 and unassigned philippotto Jul 6, 2021
@fm3 fm3 enabled auto-merge (squash) July 8, 2021 08:51
@fm3 fm3 merged commit 0efd52b into master Jul 8, 2021
@fm3 fm3 deleted the colored-job-status-icons branch July 8, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@philippotto philippotto Awaiting requested review from philippotto

Assignees

@fm3 fm3

Labels
enhancement frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add colored icons to status in jobs list
3 participants
@grittaweisheit @fm3 @philippotto