Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume tasks from file without specified Bbox #5362

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Fix volume tasks from file without specified Bbox #5362

merged 3 commits into from
Apr 7, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 6, 2021

URL of deployed dev instance (used for testing):

Steps to test:

  • Create explorational volume, brush some, download
  • Create volume task type
  • Create task, select the volume task type, select “from NML”, select the downloaded zip
  • As user, fetch the task, previously brushed data should be present

Issues:

@fm3 fm3 requested a review from youri-k April 6, 2021 07:04
@fm3 fm3 self-assigned this Apr 6, 2021
youri-k
youri-k approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly 🎉

@fm3 fm3 enabled auto-merge (squash) April 7, 2021 11:42
@fm3 fm3 merged commit cb11790 into master Apr 7, 2021
@fm3 fm3 deleted the volume-task-bbox branch April 7, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating Task from volume zip: empty bbox not replaced by full one
2 participants
@fm3 @youri-k