Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change shading of meshes #5326

Merged
merged 7 commits into from
Mar 24, 2021
Merged

Change shading of meshes #5326

merged 7 commits into from
Mar 24, 2021

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Mar 23, 2021 •
edited
Loading

This PR changes the way loaded meshes are rendered from rendering the normals to lambert-shading which is used for the isosurface-meshes.

URL of deployed dev instance (used for testing):

Steps to test:

  • Open a hybrid tracing.
  • Upload a mesh using the meshes tab
  • The mesh should now have a color and the normal should no longer be rendered. The way the loaded mesh is rendered should be the exact same way isosurfaces are rendered.

Issues:

@MichaelBuessemeyer MichaelBuessemeyer self-assigned this Mar 23, 2021
@MichaelBuessemeyer MichaelBuessemeyer changed the title [WIP] Change shading of meshes Change shading of meshes Mar 23, 2021
@MichaelBuessemeyer MichaelBuessemeyer marked this pull request as ready for review March 23, 2021 11:53
daniel-wer
daniel-wer approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works very well 👍

stl_shading

@MichaelBuessemeyer MichaelBuessemeyer merged commit b0b7c62 into master Mar 24, 2021
@normanrz normanrz deleted the change-mesh-shading branch March 24, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@MichaelBuessemeyer MichaelBuessemeyer

Labels
enhancement frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mesh shading looks weird
2 participants
@MichaelBuessemeyer @daniel-wer