Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix “merging” a single volume annotation #5198

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Fix “merging” a single volume annotation #5198

merged 2 commits into from
Feb 24, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 22, 2021

Merging multiple annotations is implemented by reduceLeft(mergeTwo) – so if only one goes in, it is returned unchanged.
This means, the version reset was not executed in this case, which lead to errors for volume annotations.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create volume tasktype, project and single-instance task. request it, trace and finish
  • As admin, click view in task list (not individual user instance), should see volume data

Issues:


@fm3 fm3 self-assigned this Feb 22, 2021
@fm3 fm3 requested a review from youri-k February 22, 2021 11:24
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 enabled auto-merge (squash) February 24, 2021 08:33
@fm3 fm3 merged commit 8af51a2 into master Feb 24, 2021
@fm3 fm3 deleted the fix-merge-volumes branch February 24, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging volume annotations by id fails for single id
2 participants