Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiuser email lookup #5152

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Fix multiuser email lookup #5152

merged 3 commits into from
Feb 11, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 10, 2021

When users signed up with an email adress that was already in use, an SQL error was produced. The end user presumably still got the correct error message on the top level, albeit with a strange error tail.

Also in this PR: removed a superfluous multiUser lookup in user update

Steps to test:

  • CI should be green
  • Try registering with existing email, should get readable error

Issues:


  • Ready for review

@fm3 fm3 self-assigned this Feb 10, 2021
@fm3 fm3 requested a review from youri-k February 10, 2021 13:40
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 added the automerge label Feb 11, 2021
@bulldozer-boy bulldozer-boy bot merged commit 3115969 into master Feb 11, 2021
@bulldozer-boy bulldozer-boy bot deleted the email-lookup branch February 11, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken user lookup?
2 participants