Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow deactivating oneself #5070

Merged
merged 6 commits into from
Jan 25, 2021
Merged

Disallow deactivating oneself #5070

merged 6 commits into from
Jan 25, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 21, 2021 •
edited
Loading

( Note that this also includes pr #5073 Run snapshot tests without concurrency for deterministic ordering )

Steps to test:

  • As admin or team manager, go to user page, try to deactivate yourself, should get readable error
  • Should still be allowed to deactivate other users

Issues:

@fm3 fm3 self-assigned this Jan 21, 2021
@fm3 fm3 added the backend label Jan 21, 2021
@fm3 fm3 marked this pull request as ready for review January 21, 2021 11:46
@fm3 fm3 requested a review from youri-k January 21, 2021 11:46
@fm3
Copy link
Member Author

fm3 commented Jan 21, 2021

@youri-k The CI still fails here, which is fixed with new snapshots in the sub-PR #5073 – yet I’d suggest you review this one already, while the diff shows only the semantic changes :)

youri-k
youri-k approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit 79b4918 into master Jan 25, 2021
@fm3 fm3 deleted the self-deactivate branch January 25, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not allow deactivating oneself snapshot tests: ensure deterministic ordering for snapshots
2 participants
@fm3 @youri-k