Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Dataset Managers to create explorative annotations on all datasets #5037

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Allow Dataset Managers to create explorative annotations on all datasets #5037

merged 3 commits into from
Jan 7, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 7, 2021 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • Register additional user, grant Dataset Manager role
  • as that user, try to create Explorative Annotation on a dataset that has zero allowed teams
  • should be allowed

Issues:

@fm3 fm3 self-assigned this Jan 7, 2021
@fm3 fm3 requested a review from youri-k January 7, 2021 14:26
youri-k
youri-k approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@fm3 fm3 merged commit 0033938 into master Jan 7, 2021
@fm3 fm3 deleted the dataset-manager-create-explorative branch January 7, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should Dataset Managers be allowed to create Exploratives for all Datasets?
2 participants
@fm3 @youri-k