Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 'use existing segmentation layer' when that layer doesn't exist #4957

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

philippotto
Copy link
Member

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open dashboard and use "create volume tracing" and "create hybrid tracing". verify that "use existing segmentation layer" is disabled if it doesn't exist

Superseded by #4939, but this PR is meant as a a hotfix.

@philippotto philippotto self-assigned this Nov 25, 2020
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unless @normanrz wanted the whole "Use ... Segmentation Layer" sub menu to be hidden if no segmentation layer exists (in that case a click on "Start Hybrid Annotation" could directly start a hybrid annotation with a new segmentation layer as there is no other option).

@normanrz
Copy link
Member

Actually, I was hoping that the menu wouldn't be there at all and the annotation would be created right away.

@philippotto
Copy link
Member Author

Yeah, #4939 will take care of this properly, but for this hotfix I decided to go with this minimal change, since the proper solution would be a bit more involved (and would cause several merge conflicts). Is this alright?

@normanrz
Copy link
Member

Alright

@philippotto philippotto merged commit 7f29716 into master Nov 26, 2020
@philippotto philippotto deleted the hotfix-fallback-dropdown branch November 26, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants