Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken overwrite-mode behavior #4920

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix broken overwrite-mode behavior #4920

merged 1 commit into from
Nov 9, 2020

Conversation

philippotto
Copy link
Member

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I used both brush and trace tool with left/right click (for draw vs delete) to test both overwrite-behaviors (via ctrl and mode switch)

Issues:

@philippotto philippotto self-assigned this Nov 9, 2020
daniel-wer
daniel-wer approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bulldozer-boy bulldozer-boy bot merged commit fc19afb into master Nov 9, 2020
@bulldozer-boy bulldozer-boy bot deleted the fix-overwrite-modes branch November 9, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer