-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve group expansion handling in the tree view #4897
Conversation
…roup expansion state, where groups were missing which led to strange behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Works very well for me 👍 If it's easy, it would be great if this PR could also take care of marking empty groups as indeterminate :)
This "annoyance" has become even more prominent with the recent change that doesn't render the tree tab when it's not visible, because when switching to another tab and back to the tree tab all groups are expanded again.
Oh, I wasn't aware of this downside. I would imagine that this can be very annoying in the long run. I see multiple options for this:
- only avoid rendering of the tree tab if there are lots of trees (since the impact won't be large otherwise)
- remember the collapse/expanded information somewhere else (e.g., in the store)
- keep the tree hierarchy view alive (i.e., move the dom visibility observer deeper down the rendering tree) while still avoiding doing react's reconcilation & co
frontend/javascripts/oxalis/view/right-menu/tree_hierarchy_view_helpers.js
Outdated
Show resolved
Hide resolved
might also be necessary, if we want to persist that information across reloads |
frontend/javascripts/oxalis/view/right-menu/tree_hierarchy_view_helpers.js
Outdated
Show resolved
Hide resolved
…lableminds/webknossos into improve-tree-view-expansion-handling
All parent groups of the active tree or group are expanded, nevertheless, which doesn't change with this PR.
This PR doesn't persist the expansion state across reloads - this is another issue.
URL of deployed dev instance (used for testing):
Steps to test:
-> The group expansion state should not change (on master the group was collapsed now).
Issues: