Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add admins and dataset managers to dataset access list #4862

Merged
merged 4 commits into from
Oct 12, 2020
Merged

add admins and dataset managers to dataset access list #4862

merged 4 commits into from
Oct 12, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 9, 2020 •
edited
Loading

Steps to test:

  • click the plus sign left of dataset name in dataset list
  • should list admins and team managers of the dataset’s organization (if the requesting user is allowed to see them)

Issues:

@fm3 fm3 self-assigned this Oct 9, 2020
@fm3 fm3 requested a review from youri-k October 9, 2020 10:54
@fm3 fm3 marked this pull request as ready for review October 9, 2020 10:54
youri-k
youri-k approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit cdf0e63 into master Oct 12, 2020
@fm3 fm3 deleted the dataset-access-list branch October 12, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset user access list is incomplete
2 participants
@fm3 @youri-k