-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable brush in merge mode #4770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 I think a tooltip explaining why the buttons are disabled (in case they are) would be helpful to users. Otherwise they are left wondering why they cannot volume annotate. Message could be "Volume annotation is disabled while the merger mode is active." or something to that effect.
frontend/javascripts/oxalis/view/action-bar/volume_actions_view.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/action-bar/volume_actions_view.js
Outdated
Show resolved
Hide resolved
@@ -42,7 +49,9 @@ class VolumeActionsView extends PureComponent<Props> { | |||
> | |||
<RadioButton value={VolumeToolEnum.MOVE}>Move</RadioButton> | |||
<RadioButton value={VolumeToolEnum.TRACE}>Trace</RadioButton> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TRACE tool can also be used to volume annotate. It should be disabled in the same way.
I noticed that the button disabled style was broken for the dark theme header (not your fault!), because we overwrote some color values there and fixed that quickly, hope that is alright with you. Now disabled buttons are grayed out as usual and can be recognized without hovering :) |
…w.js Co-authored-by: Daniel <[email protected]>
…w.js Co-authored-by: Daniel <[email protected]>
Thanks a lot for fixing the button style! I added the tooltip and disabled the trace tool as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, one small suggestion and then LGTM 👍
Co-authored-by: Daniel <[email protected]>
This PR disables the brush when merger mode is enabled in a hybrid tracing.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Updated (unreleased) migration guide if applicableUpdated documentation if applicableAdapted wk-connect if datastore API changesNeeds datastore update after deployment