Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove fallback layer #4766

Merged
merged 12 commits into from
Aug 20, 2020
Merged

Allow to remove fallback layer #4766

merged 12 commits into from
Aug 20, 2020

Conversation

grittaweisheit
Copy link
Contributor

@grittaweisheit grittaweisheit commented Aug 14, 2020

This PR makes it possible to remove the fallback layer in a volume tracing. To do this a button in the layer settings header was added.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • start a volume or hybrid tracing with existing segmentation layer
  • go to the dataset settings
  • next to the segmentation layer's settings header should be a minus button
  • on click this should open a confirm pop up
  • when selecting ok the layers segmentation should be removed and the layer should be reloaded
  • the minus button should disappear
  • when doing a volume/hybrid tracing with a task the button should not be there

Issues:


Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is a really cool change which will allow us to remove some cognitive load from the users' minds 🎉

I'd suggest a few subtle changes, though:

  • <Icon type="stop" /> fits a bit better in my opinion
  • Change the wording to "Unlink dataset's original segmentation layer" ("Remove Layer" could be confusing since the actual volume layer will still be there) in the button's tooltip
  • Add a more detailed explanation to the modal. I had a discussion with Tom and he suggested:
Are you sure you want to unlink the dataset's original segmentation layer from this tracing?

This dataset already contains a segmentation layer provided by its author. If you do not wish to base your work on this original segmentation, you can unlink it by confirming this dialog.
Note, that this action cannot be undone. Also note, if you already started with your annotation work based on the original segmentation layer, some small chunks of the segmentation might have already been merged into your annotation for technical reasons.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I left some final comment about tweaking the modal's appearance a bit. After this is done, this should be ready to be merged :)

@grittaweisheit grittaweisheit merged commit d528701 into master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to remove fallback layer from a volume tracing
3 participants