-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to remove fallback layer #4766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is a really cool change which will allow us to remove some cognitive load from the users' minds 🎉
I'd suggest a few subtle changes, though:
<Icon type="stop" />
fits a bit better in my opinion- Change the wording to "Unlink dataset's original segmentation layer" ("Remove Layer" could be confusing since the actual volume layer will still be there) in the button's tooltip
- Add a more detailed explanation to the modal. I had a discussion with Tom and he suggested:
Are you sure you want to unlink the dataset's original segmentation layer from this tracing?
This dataset already contains a segmentation layer provided by its author. If you do not wish to base your work on this original segmentation, you can unlink it by confirming this dialog.
Note, that this action cannot be undone. Also note, if you already started with your annotation work based on the original segmentation layer, some small chunks of the segmentation might have already been merged into your annotation for technical reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I left some final comment about tweaking the modal's appearance a bit. After this is done, this should be ready to be merged :)
This PR makes it possible to remove the fallback layer in a volume tracing. To do this a button in the layer settings header was added.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Updated (unreleased) migration guide if applicableUpdated documentation if applicableAdapted wk-connect if datastore API changesNeeds datastore update after deployment