Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warning for failed bucket requests less aggressive #4765

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 14, 2020

... and easier to understand
Also:

  • refactor detailed toasts
  • catch uncaught promise when client or server is offline
  • fix toast layout for firefox
  • increase bucket timeout from 30s to 60s

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open a tracing
  • turn off internet connection via dev tools
  • observe toasts
  • they will look like this:
    image

Issues:


… understand; refactor detailed toasts; catch uncaught promise when client or server is offline; fix toast layout for firefox
@philippotto philippotto requested a review from fm3 August 14, 2020 09:04
@philippotto philippotto self-assigned this Aug 14, 2020
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


.ant-notification-notice-message-single-line-auto-margin {
// This fixes a too large margin-top for the notification content in Firefox
float: left;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@philippotto philippotto merged commit 4cf0318 into master Aug 17, 2020
@philippotto philippotto deleted the improve-bucket-failures branch August 17, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Toast for a few bucket request timeouts is too obtrusive
2 participants