-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to move nodes #4743
Conversation
|
…es in a row. * And also center the after undo or redo correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelBuessemeyer Just a small note regarding your last two commits. Also, please add the new shortcuts to the shortcut overview page :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!! Works very well 👍
Moving a node can be a tad laggy, but I think this is alright for this feature. However, I noticed two things which should probably be improved before merging:
- moving does not work in a hybrid tracing (have a look at
getPlaneMouseControls
inplane_controller.js
) - the move-shortcuts don't repeat when being pressed down. If I want to move a node by 20 pixels, I have to hit the shortcut 20 times?
frontend/javascripts/oxalis/controller/combinations/skeletontracing_plane_controller.js
Show resolved
Hide resolved
good catch 👍 |
@philippotto I applied all of your feedback except one thing (see my comment). Could you please have a look at this PR again? |
frontend/javascripts/oxalis/controller/combinations/volumetracing_plane_controller.js
Outdated
Show resolved
Hide resolved
|
…ler.js Co-authored-by: Philipp Otto <[email protected]>
@philippotto I just adapted the merger mode to work correctly when nodes are moved. Could you please check this PR again? I added a section on how to test the merger mode to the description. The description is rather easy 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Works very well. I left some smaller changes, but apart from these, the PR should be good to merge :)
Co-authored-by: Philipp Otto <[email protected]>
Add the possibility to move nodes by adding an action/reducer and by making the WebGL buffer updater (
skeleton.js
) update node and edge positions.The active node can be moved using "Ctrl + Arrow Keys" or by using "Ctrl + LeftMouseDrag".
URL of deployed dev instance (used for testing):
Steps to test:
Open a tracing and move nodes using the mentioned keyboard and mouse controls.
Testing the merger mode:
Issues:
[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment