Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Warning When Creating Inaccessible Tasks #4695

Merged
merged 5 commits into from
Jul 8, 2020
Merged

Show Warning When Creating Inaccessible Tasks #4695

merged 5 commits into from
Jul 8, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 6, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create tasks for dataset with no allowed teams (bulk + individual) → warning should be shown
  • create tasks for dataset with allowed team matching the project team (bulk + individual) → no warning should be shown
  • edit dataset: no annoying “are you sure?” popup anymore

Issues:

@fm3 fm3 self-assigned this Jul 6, 2020
@fm3 fm3 requested review from philippotto and youri-k July 6, 2020 12:10
philippotto
philippotto reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 Front-end looks good to me. Didn't test yet. Probably makes more sense after the back-end was reviewed, too.

youri-k
youri-k approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. See my little suggestion, otherwise code looks good

@fm3 fm3 merged commit 630607d into master Jul 8, 2020
@fm3 fm3 deleted the task-creation-access-warning branch July 8, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto left review comments

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend frontend
Projects
None yet
Milestone
No milestone
3 participants
@fm3 @philippotto @youri-k