Ensure that the interpretation of bounding boxes is always half-open #4690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bounding box is defined with [0, 0, 0, 10, 10, 10], the position [10, 10, 10] should be outside of the bounding box. This interpretation was not consistent within the code base which I cleaned up with this PR. I tried to go through all the relevant code and double-check / fix it where necessary. Predominantly, the following two cases needed fixing:
URL of deployed dev instance (used for testing):
Steps to test:
window.webknossos.apiReady(3).then(api => window.api = api)
api.tracing.centerPositionAnimated([8, 5, z])
where z can be something like 9, 9.9, 10, 10.01 etc.Issues: