Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent false version mismatches when saving annotations #4591

Merged
merged 5 commits into from
May 6, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 4, 2020

During fossildb restart some save requests were wrongly answered with 409 CONFLICT (version mismatch, expected 1 got 313), when they should have been answered with 400 (or 500, or anything that doesn’t prevent the frontend from retrying). This was caused by falling back to 0 not only if the error cause was no-such-element (in which case 0 is correct), but always. This PR adds this distinction.

URL of deployed dev instance (used for testing):

  • dev instance testing is difficult since we can’t kill the fossildb there.

Steps to test:

  • create tracing, save some versions (should work with old and new tracings)
  • kill fossildb (or restart server without fossildb, e.g. comment it out in tools/proxy/proxy.js), but keep tracing tab open. saving should now fail, but not with error 409, frontend should say “retrying”

Issues:


@fm3 fm3 self-assigned this May 4, 2020
@fm3 fm3 requested a review from youri-k May 4, 2020 11:19
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit 40a90ea into master May 6, 2020
@fm3 fm3 deleted the version-avoid-silent-fail branch May 6, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version mismatch during fossildb restart
2 participants