Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Client Timestamp for info/finish timetracking #4580

Merged
merged 7 commits into from
Apr 29, 2020
Merged

Use Client Timestamp for info/finish timetracking #4580

merged 7 commits into from
Apr 29, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 28, 2020 •
edited
Loading

If the client and server clock are not in sync, the timespans are not merged correctly. This does not lead to large differences (we’ve seen about 1 second per task) but it creates extra confusion in the time tracking view.
This PR uses the client clock for timetracking of info and finish requests.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • trace some tasks
  • in time tracking view, there should not be overlapping extra entries
  • times should look reasonable

Issues:

  • updated API docs
  • updated changelog
  • Ready for review

@fm3 fm3 self-assigned this Apr 28, 2020
@fm3 fm3 changed the title [WIP] Use Client Timestamp for info/finish timetracking Use Client Timestamp for info/finish timetracking Apr 28, 2020
@fm3 fm3 requested a review from youri-k April 28, 2020 15:26
@fm3 fm3 marked this pull request as ready for review April 28, 2020 15:26
@fm3 fm3 added the backend label Apr 28, 2020
youri-k
youri-k suggested changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good apart from my comment for the documentation. After these changes, this is good to go 🙂

docs/rest_api.md Outdated Show resolved Hide resolved
@fm3 fm3 added the automerge label Apr 29, 2020
@bulldozer-boy bulldozer-boy bot merged commit 5723fd3 into master Apr 29, 2020
@bulldozer-boy bulldozer-boy bot deleted the client-timestamps branch April 29, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
automerge backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time tracking disparities
3 participants
@fm3 @youri-k @philippotto