Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segmentation opacity in recommended tasktype #4545

Merged
merged 5 commits into from
Apr 14, 2020
Merged

Fix segmentation opacity in recommended tasktype #4545

merged 5 commits into from
Apr 14, 2020

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 14, 2020 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • edit the existing task type to use recommended settings
  • edit the segmentation opacity in the recommended settings to another value X
  • create a task
  • get that task
  • ensure that the segmentation opacity is listed there
  • accept the settings
  • check that the opacity was set to X

Issues:

@philippotto philippotto self-assigned this Apr 14, 2020
daniel-wer
daniel-wer approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, testing went very well 👍

LGTM if the default is adjusted :)

frontend/javascripts/oxalis/view/new_task_description_modal.js
() => {
this.allowClose();
},
process.env.NODE_ENV === "production" ? 10000 : 2000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

frontend/javascripts/admin/tasktype/recommended_configuration_view.js Outdated Show resolved Hide resolved
@bulldozer-boy bulldozer-boy bot merged commit 39e03a3 into master Apr 14, 2020
@bulldozer-boy bulldozer-boy bot deleted the fix-segmentation-opacity-in-recommended-tasktype branch April 14, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can’t edit task type due to segmentation opacity
2 participants
@philippotto @daniel-wer