Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable wrap-in-group option when importing single NML #4489

Merged
merged 5 commits into from
Mar 25, 2020
Merged

Enable wrap-in-group option when importing single NML #4489

merged 5 commits into from
Mar 25, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 19, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Drag single NML into tracing view, you should still have the option to wrap its trees in a group

Issues:

@fm3 fm3 added the frontend label Mar 19, 2020
@fm3 fm3 self-assigned this Mar 19, 2020
@fm3 fm3 requested a review from philippotto March 25, 2020 13:49
philippotto
philippotto approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I really like the level of detail you put in the different single/multi file cases 👍

@fm3 fm3 added the automerge label Mar 25, 2020
@bulldozer-boy bulldozer-boy bot merged commit bd81a37 into master Mar 25, 2020
@bulldozer-boy bulldozer-boy bot deleted the nml-import-group branch March 25, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
automerge frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to create group when Importing single NML into tracing
2 participants
@fm3 @philippotto