-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix displayed segment #4480
Fix displayed segment #4480
Conversation
@philippotto I would like to make the solution a bit more fancy: My problem is that I cannot determine when there actually is no data when render missing data black is turned on. The reason is, that for the missing resolutions buckets filled with |
I'm not sure whether that's really necessary. What would be the usecase? For normal EM data, we don't show any information like that either. I'm afraid this makes the code and UI more convoluted without adding much value 🙈 But maybe I'm not understanding the usecase yet. So, feel free to argue back :D |
My idea was to simply inform the user with a warning that the display segment id (0) is wrong and also tell why that might be the case. I especially had the dataset layer settings in mind. In the settings tab, a warning info icon is rendered when not all layers are visible. That is what I am thinking about here. But on the other hand, the warning might not be necessary when we follow the rule "what you see is what you get". Because the warning would only be shown if no segmentation data can be found and rendered. Thus it might be obvious that the displayed 0 as segment id is wrong. Leaving this point aside, I would be grateful if you would review the current code 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my one comment :)
frontend/javascripts/oxalis/view/right-menu/mapping_info_view.js
Outdated
Show resolved
Hide resolved
…-displayed-segment-id
@philippotto Thanks for paying attention and finding my mistake 👍. I implemented your feedback. Could you please review the newest changes again :D? Now the resolution/magnification has its own column and the zoom step for the mouse position is determined on its own. I tried to keep the code as understandable as possible. If you have any suggestions on how to improve it, I'll be glad to implement them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
This PR adds looking for segmentation ids in higher resolutions when the current resolution has no data and render missing data black is disabled for the
segmentation tab
/mapping_info_view
.URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment