New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix float histogram #4468

Merged

youri-k merged 2 commits into master from fix-float-histogram

Mar 10, 2020

Contributor

youri-k commented Mar 9, 2020 •

edited

Loading

prevent dividing by 0

URL of deployed dev instance (used for testing):

https://___.webknossos.xyz

Steps to test:

have a float layer where all non-zero values are equal
histogram should work

Issues:

might fix ArrayIndexOutOfBoundsException in histogram call for uint16 layer #4405

Updated changelog
~~[ ] Updated migration guide if applicable~~
~~[ ] Updated documentation if applicable~~
~~[ ] Adapted wk-connect if datastore API changes~~
Needs datastore update after deployment
Ready for review


          prevent dividing by 0

0589a38

youri-k requested review from normanrz and fm3

March 9, 2020 11:45

youri-k self-assigned this

normanrz approved these changes

View reviewed changes

Member

normanrz left a comment

lgtm


          Update CHANGELOG.md

a85791d

youri-k merged commit 64a9583 into master

fm3 deleted the fix-float-histogram branch

March 20, 2020 08:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet