Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow editing description of someone else’s annotation #4466

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Disallow editing description of someone else’s annotation #4466

merged 4 commits into from
Mar 10, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 4, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • set up two users, create a tracing
  • open the tracing as owner, also as not the owner
  • owner should be allowed to edit description, other user should just see it

Issues:

@fm3 fm3 self-assigned this Mar 4, 2020
@fm3 fm3 requested review from philippotto and youri-k March 4, 2020 15:53
philippotto
philippotto approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just consider my one suggestion

@fm3 fm3 added the automerge label Mar 10, 2020
@bulldozer-boy bulldozer-boy bot merged commit 8fc2c3d into master Mar 10, 2020
@bulldozer-boy bulldozer-boy bot deleted the dont-edit-readonly-props branch March 10, 2020 16:05
@fm3 fm3 mentioned this pull request Apr 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

@youri-k youri-k Awaiting requested review from youri-k

Assignees

@fm3 fm3

Labels
automerge backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

users should not be able to edit description of someone else’s annotation
2 participants
@fm3 @philippotto