-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use back-end upload if NML is dragged into a read-only view #4459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks very good, nicely done!
However, during testing I immediately ran into the two problems:
- .proto files cannot be uploaded in the backend
- a message that the dataset cannot be found by the backend
I understand that these are limitations of the backend upload, but maybe we can mitigate them somewhat. 1) is probably not that important as we're the only ones uploading proto files. For 2) we could either substitute the dataset name in the nml with the current dataset name or add an additional dataset overwrite parameter for the backend upload.
What do you think?
frontend/javascripts/oxalis/view/layouting/tracing_layout_view.js
Outdated
Show resolved
Hide resolved
…racing from an NML (does not compile yet)
Sending a parameter to the backend sounds good to me. I prepared a commit for this, but the back-end part doesn't compile, since I don't know enough about scala 🤷♂️ @youri-k Could you have a look at this if you have a moment? The dataset name might also need to be incorporated into the tracing objects, but I'm not sure about that. Feel free to ask me if anything is unclear. |
I pushed a fix for the backend, and tested that this does indeed work nicely! |
new version fixes that also :) |
@fm3 Thanks for the fix! Works very well! I only noticed one thing: If try to upload multiple NMLs which were downloaded from a hybrid tracing, the back-end throws
Yes, since we don't explicitly advertise this, I think the current way is fine. |
Hmm, not super easy I’m afraid. I’d create a separate issue for that. For now, to upload those nmls the user will have to remove the |
@daniel-wer I think this PR would be ready to be merged. Would you agree/accept? |
@fm3 If you accept this, I think we can merge this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me :) Did not review the js code in deatil, though
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Updated migration guide if applicableUpdated documentation if applicableAdapted wk-connect if datastore API changesNeeds datastore update after deployment