Ensure appropriate width of table columns #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making the dataset name clickable to view is in progress
…e-tables-scrollable
…e-tables-scrollable
…e-tables-scrollable
…knossos into make-tables-scrollable
…e-tables-scrollable
…knossos into make-tables-scrollable
…knossos into make-tables-scrollable
MichaelBuessemeyer
changed the title
philippotto
reviewed
Jul 30, 2019
There was a problem hiding this comment.
Nice! Could you also add the following CSS rule?
.ant-table-column-title {
word-break: normal;
}
This ensures that the column headers don't break into single letters per line when the window is very narrow. The remaining behavior should still work as expected, as far as I see.
philippotto
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a fixed width to all columns of the exploration and dataset table. Thereby fixes followup of issue #4106.
URL of deployed dev instance (used for testing):
Steps to test:
Open the dataset table and resize your window. In fullscreen, the whole table should be visible without a scrolling bar at the bottom of the page. Making the window smaller, the scrollbar should appear and all columns should still have a reasonable width.
Same goes for the explorative annotations table. Please check both of them :)
Compared to the current version the difference can clearly be seen in the active and public column of the dataset table.
Please also check if you think the fixed width of each column is appropriate or should be changed.
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment