Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress ResizeObserver loop errors #4205

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jul 26, 2019

See https://stackoverflow.com/a/50387233/896760.
I don't know from where exactly the error is coming from (multiple of the required npm packages use that observer, e.g. antd), but in the end it doesn't really matter since we are suppressing it, anyway. In my browser, the "message" attribute was the only usable identifier for the error, which is why I used that for blacklisting.

URL of deployed dev instance (used for testing):

Steps to test:

  • go to the statistics > time tracking view
  • load up some time data
  • resize the browser as if you were on fire
  • --> only a warning should be logged to the console

Issues:


@philippotto philippotto self-assigned this Jul 26, 2019
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍

@daniel-wer daniel-wer merged commit 9277826 into master Jul 29, 2019
@daniel-wer daniel-wer deleted the suppress-resize-observer-errors branch July 29, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants