Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load data for disabled or invisible layers #4202

Merged
merged 5 commits into from
Jul 29, 2019
Merged

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Jul 25, 2019

/cc @MichaelBuessemeyer This is somewhat relevant for your issue #4044 as well, so you could have a look at this PR as well :)

Also, I fixed a bug where the shader crashed when there were multiple float layers 🙈 (Will be obsolete with the Histogram PR as well, though) :)

URL of deployed dev instance (used for testing):

Steps to test:

  • Open a dataset with many layers, disable some of them or set alpha to 0. Move around - data should quicker than when all layers were enabled and you should only see bucket requests for visible layers in the network tab.
  • Open a dataset with a segmentation layer. Switch to arbitrary mode. - You should see no requests for segmentation buckets in the network tab.

Issues:


@CLAassistant
Copy link

CLAassistant commented Jul 25, 2019

CLA assistant check
All committers have signed the CLA.

@philippotto
Copy link
Member

Excellent PR! 👍 The code is much clearer now and I'm looking forward to the speed gains 🍬

I'll test when the CI passes ;)

@daniel-wer
Copy link
Member Author

@philippotto Ready to test :)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawlessly 👍

@daniel-wer daniel-wer merged commit 8562872 into master Jul 29, 2019
@daniel-wer daniel-wer deleted the save-bandwidth branch July 29, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not load data for data layers with an alpha value of 0
3 participants