Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrambled uint24 data #4188

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Fix scrambled uint24 data #4188

merged 3 commits into from
Jul 17, 2019

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Jul 16, 2019 •
edited
Loading

The channel count for uint24 layers was not used when initializing an empty buffer, leading to buffers that were too small, leaving old data in the data texture.

URL of deployed dev instance (used for testing):

Steps to test:

  • Already tested

Issues:

@daniel-wer daniel-wer added the bug label Jul 16, 2019
@daniel-wer daniel-wer self-assigned this Jul 16, 2019
philippotto
philippotto approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@daniel-wer
Copy link
Member Author

Screenshot tests are green, will merge now :)

@daniel-wer daniel-wer merged commit aa3a872 into master Jul 17, 2019
@daniel-wer daniel-wer deleted the fix-scrambled-uint24 branch July 17, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@daniel-wer daniel-wer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrambled data for missing magnification
2 participants
@daniel-wer @philippotto