-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add histogram to dataset settings #4105
Add histogram to dataset settings #4105
Conversation
…-histogram-to-dataset-settings
… almost no performance
fixed flow bug
added brightness&contrast -> range conversion function -> not working; removed brightness and contrast from shader
removed brightness and contrast from the settings
@MichaelBuessemeyer can you add the remaining to dos in form of checkboxes to this PR? Or is everything done and ready for review? :) |
@philippotto As we can't convert brightness and contrast into a good approximation of the intensityRange (min and max value) and we no longer support brightness and contrast: Do you thing just replacing brightness and contrast in the dataset layer settings is fine? I think @daniel-wer also suggested this. And using default values should be fine as our customer mentioned this in the discuss 🙂 Maybe last TODOs:
|
Ok, sounds good!
Regarding the second todo: the value should be valid and accepted, but it shouldn't be required. Otherwise, all existing dataset layer settings will become immediately invalid when we deploy this. Instead, the old configurations should still be valid (so, the old brightness/contrast values are still valid and ignored and the new intensityRange is "optional"). |
brightness and contrast are no longer required
type Vector3 = Array<number>; | ||
type Vector3 = [number, number, number]; | ||
|
||
type Vector2 = [number, number]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think defining the Vectors as tuples is more accurate as it defines the length of the array
@@ -5,3 +5,7 @@ | |||
.centered-children { | |||
text-align: center; | |||
} | |||
|
|||
.tracing-settings-menu .ant-tabs-content { | |||
padding-right: 8px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some padding to the settings on the left to not get elements covered by the scrolling bar.
@philippotto This PR is ready for your review 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff! Code looks good to me. Only two things:
- For float layers, we said that we won't support the histogram in the first iteration, right? Then, I'd hide the histogram for those layers. Right now, the user can use the slider, but it won't change anything. Also, the histogram doesn't look right due to the range of 0-255.
- When disabling a layer, the min-max-slider should be disabled (and I'd argue that the histogram could also be hidden)
frontend/javascripts/oxalis/geometries/materials/plane_material_factory.js
Outdated
Show resolved
Hide resolved
@philippotto Thanks for paying attention to those points. Please note: As I do not have a dataset with float type I cannot try out the first point. And you can give this PR another of your awesome reviews :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks good to me 👍
@MichaelBuessemeyer This can be merged, right? |
@philippotto Indeed, It can. |
This PR adds the long-awaited histogram feature for to the dataset settings. It uses the new histogram backend route to get the sampled histogram data of the current dataset.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
ToDo:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment