Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reset zoom when doing a task hot swap #4049

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Don't reset zoom when doing a task hot swap #4049

merged 3 commits into from
Apr 29, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 29, 2019 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I set up multiple tasks and made a hot swap between them --> the zoom value didn't change
  • when opening a new task from the dashboard, the zoom value is properly initialized

Issues:

@philippotto philippotto self-assigned this Apr 29, 2019
@philippotto philippotto merged commit e030550 into master Apr 29, 2019
@philippotto philippotto deleted the dont-reset-zoom branch May 20, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zoom is reset after each flight mode task
2 participants
@philippotto @daniel-wer