Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nml parser should parse float coordinates of nodes #4045

Merged
merged 3 commits into from
May 2, 2019
Merged

Nml parser should parse float coordinates of nodes #4045

merged 3 commits into from
May 2, 2019

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Apr 25, 2019 •
edited
Loading

  • will do the error messages in another pr

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • upload nml containing positions of type float

Issues:

- [ ] Updated changelog
- [ ] Updated migration guide if applicable
- [ ] Updated documentation if applicable
- [ ] Adapted wk-connect if datastore API changes
- [ ] Needs datastore update after deployment

  • Ready for review

@youri-k youri-k requested review from fm3 and jstriebel April 25, 2019 17:58
@youri-k youri-k self-assigned this Apr 25, 2019
jstriebel
jstriebel reviewed Apr 26, 2019
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM! I am just not sure if we should actually round the floats, or just allow 1.0, but not 1.1 (not specified in #3979). Do you plan to add a check for that together with the errors?

@fm3
Copy link
Member

fm3 commented Apr 26, 2019

rounding should be fine (I checked back with norman and philipp)

jstriebel
jstriebel approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jstriebel
Copy link
Contributor

PS: please add a note to the changelog

@youri-k youri-k merged commit 0b0e27e into master May 2, 2019
@normanrz normanrz deleted the nml-parser-round-values branch August 12, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

@fm3 fm3 Awaiting requested review from fm3

Assignees

@youri-k youri-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NML Parser: if coordinates are float, round them
3 participants
@youri-k @fm3 @jstriebel