Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering artifacts in tasks that only allow flight mode #3783

Merged
merged 3 commits into from
Feb 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md).
- Fixed an error that occured when changing the URL hash. [#3746](https://github.com/scalableminds/webknossos/pull/3746)
- Fixed a bug in the timeline chart rendering. The start and end time of the timeline chart now match the selected time range. [#3772](https://github.com/scalableminds/webknossos/pull/3772)
- The modals for a new task description and recommended task settings are no longer shown in read-only tracings. [#3724](https://github.com/scalableminds/webknossos/pull/3724)
- Fixed a rendering bug when opening a task that only allowed flight/oblique mode tracing. [#3783](https://github.com/scalableminds/webknossos/pull/3783)
- Fixed a bug where some NMLs caused the webKnossos tab to freeze during NML upload. [#3758](https://github.com/scalableminds/webknossos/pull/3758)


Expand Down
3 changes: 3 additions & 0 deletions frontend/javascripts/oxalis/controller/scene_controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@ class SceneController {
for (const plane of _.values(this.planes)) {
plane.getMeshes().forEach(mesh => this.rootNode.add(mesh));
}

// Hide all objects at first, they will be made visible later if needed
this.stopPlaneMode();
}

buildTaskingBoundingBox(taskBoundingBox: ?BoundingBoxType): void {
Expand Down
4 changes: 4 additions & 0 deletions frontend/javascripts/oxalis/geometries/cube.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ class Cube {

setVisibility(visible: boolean) {
this.visible = visible;
this.cube.visible = visible;
for (const planeId of OrthoViewValuesWithoutTDView) {
this.crossSections[planeId].visible = visible;
}
}
}

Expand Down