List Currently Available Mappings #3720
Conversation
|
I added the corresponding UI for mappings in this PR. Should be ready to review from my point of view. |
There was a problem hiding this comment.
Awesome, I didn't think I'd live to see this day - a UI for mappings. 😁
Not having to have the browser console open to activate mappings will allow for bigger mappings as well (more available memory)!
I love the progress updates, maybe we can free up the main thread a little bit during mapping creation to avoid the hefty lag, but that is low prio and for another PR :)
I think we can get rid of the global mappings object, now, right? (setupGlobalMappingsObject and related code)
| Store.dispatch(setMappingAction(_.clone(mapping), options.colors, options.hideUnmappedIds)); | ||
| Store.dispatch( | ||
| setMappingAction( | ||
| "<code provided>", |
There was a problem hiding this comment.
Maybe change to <user provided mapping> or <custom mapping> - I did not understand what was meant here at first.
| return; | ||
| } | ||
| this.setState({ isRefreshingMappingList: true }); | ||
| const layerName = "segmentation"; |
There was a problem hiding this comment.
Shouldn't this be this.props.segmentationLayer.name?
There was a problem hiding this comment.
My hope was that this will allow mappings even when there is a new volume tracing layer, however, this doesn't work, since the actual mappings are downloaded via an url which is defined somewhere also (and again with the segmentation layer's name). I could change it there too, but in general, this is brittle, since a segmentation layer can have different names on disk, as well. So, I went back to using the actual layer name here. It's still an improvement to before.
We should rethink how we want to handle the disk segmentation layer VS volume tracing layer in the future.
|
|
||
| export type ProgressCallback = (isDone: boolean, progressState: string) => Promise<void>; | ||
|
|
||
| export default function createProgressCallback(options: { |
There was a problem hiding this comment.
Nice! We can probably re-use this in the future 🥇
|
@fm3 Can you verify that the checkboxes are set appropriately? :) Not sure whether a datastore update is needed? |
URL of deployed dev instance (used for testing):
Steps to test:
http://localhost:9000/data/datasets/Connectomics_Department/ROI2017_wkw/layers/segmentation/mappings?token=secretScmBoyTokenScreenshot & Gif
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable