Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to import NMLs which were created for different datasets #3716

Merged
merged 6 commits into from
Feb 4, 2019
Merged

Allow to import NMLs which were created for different datasets #3716

merged 6 commits into from
Feb 4, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Feb 4, 2019 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • create a tracing with some trees and download these as NML
  • change the "experiment.name" parameter within the NML
  • import the NML via dnd
  • a modal should ask whether you are sure to import the nml

Issues:

@philippotto philippotto self-assigned this Feb 4, 2019
daniel-wer
daniel-wer approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

app/assets/javascripts/oxalis/view/right-menu/trees_tab_view.js Outdated
const currentDatasetName = Store.getState().dataset.name;
const doDatasetNamesDiffer = importActionsWithDatasetNames
.map(el => el.datasetName)
.some(name => name != null && name !== currentDatasetName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty experiment name name="" will trigger the confirm. I'd say it would be better to add && name.length > 0 after the null check.

@philippotto philippotto merged commit 316adbf into master Feb 4, 2019
@normanrz normanrz deleted the allow-different-dataset-nml branch February 20, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NML Format: Allow parameters.experiment.name to be empty Allow NML import of different datasets
2 participants
@philippotto @daniel-wer