Route to find data #3682
Route to find data #3682
Conversation
| ) | ||
| for { | ||
| (data, _) <- requestData(dataSource, dataLayer, request) | ||
| if data.nonEmpty |
There was a problem hiding this comment.
This syntax is new to me, can we get rid of bool2Fox this way?
However, nonEmpty does not suffice, since the array is still nonEmpty if it contains 32768 zeroes. And indeed, the route always returns the center of the bounding box for me
|
Front-end part is finished. I added a subtle icon next to the layers in the dataset settings. Strictly speaking, it's not a setting, but I didn't want to clutter our menus with more random stuff. The tooltip text also might need iteration. Feel free to leave feedback! For the record, @youri-k is going to push another commit to improve the actual find-data route. |
… into find-data-route
|
Sadly the code isn't working right now and I don't know why. One culprit is the HashSet that does not save values through iterations. Maybe @fm3 you have an idea, what to do next? |
|
@youri-k can you test if the hashset has this problem? How is it passed between iterations / how is ensured that they all use the same? |
|
I changed the implementation back to the original idea, as I figured out that it didn't really matter. |
| @@ -13,6 +13,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md). | |||
|
|
|||
| - Added the possibility to create volume annotation tasks. When creating a task type, select whether to create `volume` or `skeleton` tasks. Note that compound viewing for volume tasks is not supported yet. Same for creating volume tasks from uploaded nml/data files. [#3712](https://github.com/scalableminds/webknossos/pull/3712) | |||
| - Added an UI to select a mapping for a segmentation layer. The UI is placed in the segmentation tab within the tracing view. [#3720](https://github.com/scalableminds/webknossos/pull/3720) | |||
| - Added a button to jump to actual data if the bounding box of a dataset contains a lot of black data. [#3682](https://github.com/scalableminds/webknossos/pull/3720) | |||
There was a problem hiding this comment.
fixed the link here: #3821
GET http://localhost:9000/data/datasets/Connectomics_Department/ROI2017_wkw/layers/color/findData?token=secretScmBoyTokenURL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable