Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Team Managers to create (and own) Scripts #3676

Merged
merged 7 commits into from
Jan 28, 2019
Merged

Allow Team Managers to create (and own) Scripts #3676

merged 7 commits into from
Jan 28, 2019

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 24, 2019 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • create second user, activate, make team manager
  • as that user, create a script, should work
  • owner drop-down menu should include all team managers of the organization

Issues:

youri-k
youri-k approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM :shipit:

@fm3 fm3 self-assigned this Jan 24, 2019
@fm3 fm3 merged commit 5099d80 into master Jan 28, 2019
@normanrz normanrz deleted the allow-teammanager-to-create-script branch February 20, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Team Managers should be allowed to create scripts
3 participants
@fm3 @philippotto @youri-k