Separate Statistics per Organization #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstriebel
reviewed
Jan 23, 2019
| notdel(r) && (r.created >= new java.sql.Timestamp(start.getOrElse(0))) && r.created <= new java.sql.Timestamp( | ||
| end.getOrElse(MAX_TIMESTAMP))) | ||
| .result) | ||
| r <- run(sql"""select #${columnsWithPrefix("t.")} from #${existingCollectionName} t |
There was a problem hiding this comment.
I'm wondering why we can't use the scala slick syntax here. Or do you simply prefer SQL?
There was a problem hiding this comment.
In my first draft, I was going to use the accessQueries to find all items in the visible scope of the requesting user, rather than filter by organization (that would have required sql syntax). However, it turned out that leads to inconsistencies e.g. with public datasets. So I changed course, but I didn’t change this code back to slick syntax.
However, I think the more complex the query, the easier to write and read is SQL compared to slick syntax. Since we introduced a join here, I’d keep this change.
jstriebel
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Needs datastore update after deployment