-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign dataset gallery as publication gallery #3653
Conversation
…to redesign-spotlight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had this review pending and forgot to submit it (and I think, my typed text is also gone 🤔)
The redesign looks really good! If datasets without publications are filtered away, the mhlab instance will have a blank page then, right? Or is the filtering configurable?
const activeDataset = hoveredDataset || selectedDataset; | ||
const { publication } = activeDataset; | ||
// This method will only be called for datasets with a publication, but Flow doesn't know that | ||
if (publication == null) return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd even throw an error instead of returning null, since this should never happen, anyway. If it happens for some reason, we will notice it faster.
I played around with it on https://redesignspotlight.webknossos.xyz. To me it feels weird that you first have to click on a dataset and then click again on the larger thumbnail to get into the data. |
…sos into redesign-spotlight
This PR redesigns the dataset gallery/spotlight view and makes it a dedicated publication gallery. Datasets that are not part of a publication, are not shown. A publication consists of a name, description and a single or multiple published datasets. The publications are sorted by
publicationDate
(descending). Each dataset has a name and scale, but can also contain more details such as species, acquisition method and brain-region. Although the dataset details can contain arbitrary json in the backend, the frontend now expects a "standardized" format like:The search box currently only searches through the dataset properties. Ideally, users could search for the publication title/description as well, but I'm not sure how to decide whether the search query should apply to the publications or datasets, then.
I'm also not quite sure how to best incorporate a possible publication image, yet.
Open for design feedback :)
URL of deployed dev instance (used for testing):
Steps to test:
Issues: