Docker healthchecks #3606
Merged
Docker healthchecks #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanrz
commented
Jan 8, 2019
| command: | ||
| - fossildb | ||
| - -c | ||
| - skeletons,skeletonUpdates,volumes,volumeData,volumeUpdates | ||
| user: ${USER_UID:-fossildb}:${USER_GID:-fossildb} | ||
| healthcheck: |
There was a problem hiding this comment.
Not required anymore, because it is defined in fossildb's Dockerfile
jstriebel
reviewed
Jan 9, 2019
| @@ -16,5 +16,11 @@ RUN chown -R webknossos . \ | |||
|
|
|||
| USER webknossos | |||
|
|
|||
| HEALTHCHECK \ | |||
| --interval=1m --timeout=5s --retries=10 \ | |||
| CMD curl --fail http://localhost:9090/data/health || exit 1 | |||
There was a problem hiding this comment.
Really weird that docker allows the exit-code to be only 0 or 1.
jstriebel
suggested changes
Jan 9, 2019
There was a problem hiding this comment.
The tracingstore healthcheck does not work yet, the others look fine.
Logs from the tracingstore, but reported unhealthy:
…
webknossos-tracingstore_1 | 2019-01-09 09:18:52,238 [INFO] - Slf4jLogger started
webknossos-tracingstore_1 | 2019-01-09 09:18:53,582 [INFO] - Slf4jLogger started
webknossos-tracingstore_1 | 2019-01-09 09:18:54,539 [INFO] - Successfully tested FossilDB health at fossildb:7155. Reply: SERVING
Co-Authored-By: normanrz <[email protected]>
Co-Authored-By: normanrz <[email protected]>
jstriebel
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test:
DOCKER_TAG=docker-health__7392 docker-compose pull webknossos webknossos-datastore webknossos-tracingstoreDOCKER_TAG=docker-health__7392 docker-compose up webknossos webknossos-datastore webknossos-tracingstoredocker pswhether all services are reported healthy (after ~1min each)Issues:
- [ ] Updated migration guide if applicable- [ ] Updated documentation if applicable