-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tracing on a scratch dataset annyoing #3500
Conversation
|
||
render() { | ||
const divClassName = classnames({ | ||
"zoomstep-warning": this.props.isVolumeTracingDisallowed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had no effect anyway or why did you remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the zoomstep-warning for volume tracings no longer worked due to golden layout (red border), which is why I removed it. We're showing an error toast anyways.
Yes, it even screwed up the layout a little bit :/
I’d suggest going ahead with this and not waiting for the last feedback. It comes close to the original feature request, definitely closer than having nothing. |
I adapted the message, would go ahead and merge if someone approves the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Unfortunately it's not that easy to change the whole background of the tracing view due to golden layout. Instead, I've made the header look like a construction banner and show a warning. I'll ask for feedback on whether that is sufficient as well or whether they have another idea :)
I also noticed that the zoomstep-warning for volume tracings no longer worked due to golden layout (red border), which is why I removed it. We're showing an error toast anyways.
URL of deployed dev instance (used for testing):
Steps to test:
isScratch
property of your datastore to true in the postgres datastores table. Open a tracing and be annoyed :)Issues: