Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tracing on a scratch dataset annyoing #3500

Merged
merged 5 commits into from
Jan 3, 2019
Merged

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Nov 28, 2018

Unfortunately it's not that easy to change the whole background of the tracing view due to golden layout. Instead, I've made the header look like a construction banner and show a warning. I'll ask for feedback on whether that is sufficient as well or whether they have another idea :)

I also noticed that the zoomstep-warning for volume tracings no longer worked due to golden layout (red border), which is why I removed it. We're showing an error toast anyways.

URL of deployed dev instance (used for testing):

Steps to test:

  • Checkout the code and change the isScratch property of your datastore to true in the postgres datastores table. Open a tracing and be annoyed :)

Issues:

scratch


@daniel-wer daniel-wer self-assigned this Nov 28, 2018

render() {
const divClassName = classnames({
"zoomstep-warning": this.props.isVolumeTracingDisallowed,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had no effect anyway or why did you remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that the zoomstep-warning for volume tracings no longer worked due to golden layout (red border), which is why I removed it. We're showing an error toast anyways.

Yes, it even screwed up the layout a little bit :/

@daniel-wer daniel-wer changed the title Make tracing on a scratch dataset annyoing [Blocked] Make tracing on a scratch dataset annyoing Dec 17, 2018
@fm3
Copy link
Member

fm3 commented Dec 17, 2018

I’d suggest going ahead with this and not waiting for the last feedback. It comes close to the original feature request, definitely closer than having nothing.
One thing: /wKlive is specific to one installation. Right now, they are the only one to request that feature but I’d keep it generic anyway, maybe? Something along the lines of “Datasets on this Datastore are marked as ’scratch’” should probably be enough info for the mhlab people to recognize what they have to do. What do you think?

@daniel-wer
Copy link
Member Author

I adapted the message, would go ahead and merge if someone approves the PR :)

@daniel-wer daniel-wer changed the title [Blocked] Make tracing on a scratch dataset annyoing Make tracing on a scratch dataset annyoing Jan 2, 2019
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daniel-wer daniel-wer merged commit 3bab9ca into master Jan 3, 2019
@daniel-wer daniel-wer deleted the annoying-scratch branch January 3, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show warning for scratch datasets
3 participants