Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to access annotations of other users (if they know the link) #3348

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Allow users to access annotations of other users (if they know the link) #3348

merged 2 commits into from
Oct 11, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 11, 2018 •
edited
Loading

dev deployment for testing

Steps to test:

  • create second user (not team manager or admin)
  • as the first user, create tracing, save link, logout
  • as the non-privileged user you should see the tracing given the link (assuming you have access to the dataset)

Issues:

@fm3 fm3 self-assigned this Oct 11, 2018
youri-k
youri-k approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit 59c4b9a into master Oct 11, 2018
@fm3 fm3 deleted the allow-access-to-others-annotations branch October 11, 2018 13:23
@fm3 fm3 mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

@jfrohnhofen jfrohnhofen Awaiting requested review from jfrohnhofen

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align Behavior and Description for Sharing Tracings
2 participants
@fm3 @youri-k