Make sure texture is not updated too early since these updates get lost silently #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
Sep 24, 2018
| @@ -134,7 +136,7 @@ export default class TextureBucketManager { | |||
| } | |||
|
|
|||
| keepLookUpBufferUpToDate() { | |||
| if (this.isRefreshBufferOutOfDate) { | |||
| if (this.lookUpTexture.isInitialized() && this.isRefreshBufferOutOfDate) { | |||
There was a problem hiding this comment.
As discussed, it would be better to move this check into the startRAFLoops method and wait for the initialization of the texture, there :) Same for the check in the processWriterQueue method.
philippotto
added a commit
that referenced
this pull request
Sep 27, 2018
…st silently (#3262) * make sure texture is not updated too early since these updates get lost silently * update changelog * fix tests * refactor waiting for initialization in texture bucket manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After hours of debugging I finally found out the evil culprit:
if (!textureProperties.__webglTexture) return;. ThreeJS initializes the texture only after the initial render. However, the buckets were partially written to the texture before that. Due to the silent failure, the buckets were essentially "written" as "black" to the texture.I hope this fixes #3259, but I'm not too sure.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: