Non-public datasets accessed using a token do honor default settings #3261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this scenario the user is not logged in but using a sharing token (for those routes that allow sharing tokens as a parameter.
GET /api/dataSetConfigurations/:dataSetName
does not have the option to add a sharing token). Because of thatuserDataSetConfigurationDAO.findOneForUserAndDataset
obviously will not find anything. The problem was that.orElse(dataSetDAO.findOneByName(dataSetName).flatMap(_.defaultConfiguration))
also failed because of missing permissionSteps to test:
Issues:
[ ] Updated changelog[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Needs datastore update after deployment